|
#1
|
|||
|
|||
Bugs in 5.1
Thanks for a great response in getting this added to 5.1 guys. Unf. you've got a few bugs.
First of all there are some typos in vbld_FileDateModified that break it completely. 614: "time" s/b "Time" 617: "time" s/b "Time", in date format need "M" not "m" 621: "time::local" s/b "Time::Local" Second, you have 2 copies of vbld_AddDelimValue. The second should just override the first without really causing a problem, but it could cause maintenance issues for you in the future. Finally, just a note on style. On lines 635 and 799(781 if you deal with #2 first) you have trailing "if" modifiers. It is not required but generally considered good style to add an extra prefix tab to make these really obvious. ************************************************** ********************* The views and opinions expressed in this message are those of the author. The contents of this message have not been reviewed or approved by Intel. ************************************************** ********************* |
|
|